Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow puppet-systemd 8.x #266

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Allow puppet-systemd 8.x #266

merged 1 commit into from
Feb 7, 2025

Conversation

jay7x
Copy link
Member

@jay7x jay7x commented Dec 14, 2024

  • puppet/systemd: allow 8.x

@duritong
Copy link
Collaborator

Why are tests always failing?

@traylenator
Copy link
Collaborator

Why are tests always failing?

223) nftables::simplerule on rocky-9-x86_64 only IPv4 TCP traffic is expected to compile into a catalogue without dependency cycles
       Failure/Error: it { is_expected.to compile }
         error during compilation: Parameter enable failed on Service[firewalld]: Provider debian must have features 'maskable' to set 'enable' to 'mask' (file: /scratch/actions/actions-runner-2.305.0/instance14/_work/puppet-nftables/puppet-nftables/spec/fixtures/modules/nftables/manifests/init.pp, line: 267)
       # ./spec/defines/simplerule_spec.rb:150:in `block (5 levels) in <top (required)>'

This is when we get the wrong service provider "debian" and not "systemd'.

Thought we has some mocking somewhere to satisfy:

confine :true => Puppet::FileSystem.exist?('/proc/1/comm') && Puppet::FileSystem.read('/proc/1/comm').include?('systemd')

in the service systemd provider. Failing to find it.

@traylenator
Copy link
Collaborator

Thought we has some mocking somewhere to satisfy:

Yeah we seemed to have lost here:

65ed81b#diff-89eebfcbc0f14b6d989517837ca1e94fce4e2ce9a03233641cd936f2b8d2ed94

@traylenator traylenator mentioned this pull request Feb 5, 2025
@kenyon kenyon changed the title puppet systemd 9 Allow puppet-systemd 8.x Feb 7, 2025
@kenyon kenyon added the enhancement New feature or request label Feb 7, 2025
@bastelfreak bastelfreak merged commit 00f4cf0 into master Feb 7, 2025
17 checks passed
@bastelfreak bastelfreak deleted the puppet-systemd-9 branch February 7, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants