Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here #1327
Unfortunately, on my conveniently-available hardware (AMD running Windows), it doesn't seem to make any difference. It's definitely changing the bytecode that's sent to the driver (I checked that thoroughly after an earlier revision of this work turned out to only actually be optimising the first shader it was given)
I don't know whether that's because:
It would make a degree of sense for other people to test this on other machines - I'd be unsurprised if embedded platforms didn't bother optimising the SPIR-V they're given, but I don't have any such hardware myself.
As this seems to accomplish nothing, there might be disadvantages to merging it:
Those disadvantages would be mitigated by making the default value of
optimize
false
instead oftrue
and by not providing optimised versions of the precompiled shaders (or maybe even an optimised version and an unoptimised version).