Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): avoid merging component instance into $props in ComponentInstance #12870

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jh-leong
Copy link
Member

@jh-leong jh-leong commented Feb 13, 2025

close #12751

Previously, ComponentInstance incorrectly merged the component instance into $props, causing $props to contain an extra $xxx field.

This fix ensures that when defineComponent() is used, ComponentInstance directly resolves to the correct instance type instead of wrapping it in ComponentPublicInstance.

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 38.1 kB 34.3 kB
vue.global.prod.js 158 kB 58 kB 51.6 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.5 kB 18.2 kB 16.7 kB
createApp 54.6 kB 21.3 kB 19.4 kB
createSSRApp 58.8 kB 23 kB 21 kB
defineCustomElement 59.4 kB 22.9 kB 20.8 kB
overall 68.6 kB 26.4 kB 24 kB

Copy link

pkg-pr-new bot commented Feb 13, 2025

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12870

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12870

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12870

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12870

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12870

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12870

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12870

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12870

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12870

vue

npm i https://pkg.pr.new/vue@12870

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12870

commit: 1605a8c

@jh-leong
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Feb 13, 2025

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success success
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

@edison1105 edison1105 added the ready to merge The PR is ready to be merged. label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR is ready to be merged. scope: types
Projects
None yet
3 participants