Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(svg): apply every namespace in slot when call applyNS #11349

Closed
wants to merge 322 commits into from

Conversation

zhangzhonghe
Copy link
Member

@zhangzhonghe zhangzhonghe commented Apr 26, 2020

Fix #11315

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@cartok
Copy link

cartok commented Feb 19, 2021

Any idea when we get this? Really need it.

@cartok
Copy link

cartok commented Feb 19, 2021

Slots do not render in foreignObjects if the foreignObject is not in the template of the same component that has the root svg element of the svg. Means you can't split svg into components properly.

@posva posva changed the title fix(namespace): apply every namespace in slot when call applyNS (#11315) fix(namespace): apply every namespace in slot when call applyNS Feb 24, 2021
@posva posva changed the title fix(namespace): apply every namespace in slot when call applyNS fix(svg): apply every namespace in slot when call applyNS Feb 24, 2021
@patrick-beep
Copy link

What can we do to get this merged in? I really need this fix

webfansplz and others added 7 commits November 9, 2022 04:25
Using a WeakMap polyfill isn't ideal because the reason we tried to use
WeakMap was to work with non-extensible objects. However, WeakMap
polyfill for non-extensible objects are non-weak and could lead to
memory leaks.

The trade-off is that we remove support for `readonly()` on
non-extensible objects, which seems reasonable.

close vuejs#12837
@msetegn
Copy link

msetegn commented Nov 12, 2022

Is this going to get merged in?

@staffanpalopaa
Copy link

Have been waiting for this fix for a long time now.

@zhangzhonghe
Copy link
Member Author

I just rebased it on the latest code. I don't know why it makes this big!

@zhangzhonghe zhangzhonghe reopened this Apr 24, 2023
@zhangzhonghe
Copy link
Member Author

See #13008

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Components slots are not rendered inside svg foreignObject