Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VDataTableColumn): columns are not keyboard-accessible fixes #20899 #20939

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ankusharoraa
Copy link

@ankusharoraa ankusharoraa commented Jan 29, 2025

fixes #20899

Description

Added default tabindex to 0 for the cells in the table.

Markup:

<template>
  <v-data-table :headers="headers" :items="items" />
</template>

<script>
  export default {
    data: () => ({
      headers: [
        { title: 'Dessert (100g serving)', align: 'start', key: 'name' },
        { title: 'Calories', key: 'calories', align: 'end', sortable: false },
        { title: 'Fat (g)', key: 'fat', align: 'end' },
        { title: 'Carbs (g)', key: 'carbs', align: 'end' },
        { title: 'Protein (g)', key: 'protein', align: 'end' },
        { title: 'Iron (%)', key: 'iron', align: 'end' },
      ],
      items: [
        {
          name: 'Frozen Yogurt',
          calories: 159,
          fat: 6.0,
          carbs: 24,
          protein: 4.0,
          iron: '1',
        },
        {
          name: 'Jelly bean',
          calories: 375,
          fat: 0.0,
          carbs: 94,
          protein: 0.0,
          iron: '0',
        },
        {
          name: 'KitKat',
          calories: 518,
          fat: 26.0,
          carbs: 65,
          protein: 7,
          iron: '6',
        },
        {
          name: 'Eclair',
          calories: 262,
          fat: 16.0,
          carbs: 23,
          protein: 6.0,
          iron: '7',
        },
        {
          name: 'Gingerbread',
          calories: 356,
          fat: 16.0,
          carbs: 49,
          protein: 3.9,
          iron: '16',
        },
        {
          name: 'Ice cream sandwich',
          calories: 237,
          fat: 9.0,
          carbs: 37,
          protein: 4.3,
          iron: '1',
        },
        {
          name: 'Lollipop',
          calories: 392,
          fat: 0.2,
          carbs: 98,
          protein: 0,
          iron: '2',
        },
        {
          name: 'Cupcake',
          calories: 305,
          fat: 3.7,
          carbs: 67,
          protein: 4.3,
          iron: '8',
        },
        {
          name: 'Honeycomb',
          calories: 408,
          fat: 3.2,
          carbs: 87,
          protein: 6.5,
          iron: '45',
        },
        {
          name: 'Donut',
          calories: 452,
          fat: 25.0,
          carbs: 51,
          protein: 4.9,
          iron: '22',
        },
      ],
    }),
  }
</script>

@ankusharoraa
Copy link
Author

@johnleider - Can you please review this PR

@johnleider
Copy link
Member

This allows the focusing of the columns but no actual interaction.

@ankusharoraa
Copy link
Author

This allows the focusing of the columns but no actual interaction.

@johnleider - Bug #20899 asks only for tabbing of table cells (Actual Behavior - Sortable headers are not tabbable.)
Should I start working on the interactions of cells as well, or should there be any other feature ticket related to it?

@johnleider
Copy link
Member

To me, tab support assumes keyboard interaction for changing the sort.

@ankusharoraa ankusharoraa force-pushed the fix/20899-vDataTable-ada branch from 8697fea to eb82be7 Compare February 6, 2025 18:35
@ankusharoraa
Copy link
Author

ankusharoraa commented Feb 6, 2025

To me, tab support assumes keyboard interaction for changing the sort.

@johnleider I have added changes for keyboard interaction for changing the sort in latest commit, please review

@ankusharoraa ankusharoraa force-pushed the fix/20899-vDataTable-ada branch from 9de6a0d to 72d3e97 Compare February 7, 2025 09:52
@MajesticPotatoe MajesticPotatoe added T: bug Functionality that does not work as intended/expected C: VDataTable labels Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VDataTable T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][3.7.7] VDataTable sortable columns are not keyboard-accessible
3 participants