-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nested): don't toggle disabled children #20962
base: master
Are you sure you want to change the base?
Conversation
32e0f5c
to
1f71398
Compare
@@ -731,5 +765,51 @@ describe('selectStrategies', () => { | |||
['6', 'on'], | |||
])) | |||
}) | |||
|
|||
it('should not select disabled children when parent is selected', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return-object is usually vulnerable when nested composable has changes, so probably better add a test case to cover return-object as well
I fiddled with this and was ultimately unsuccessful in getting the clicked on element that has the disabled children to default to the indeterminate state. |
fixes #20386
Description
Markup: