-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(VDatePicker): add events and event-color support for date picker #20965
base: dev
Are you sure you want to change the base?
feat(VDatePicker): add events and event-color support for date picker #20965
Conversation
b1b33c3
to
57f55dc
Compare
57f55dc
to
ecf3e93
Compare
Hey @johnleider, I appreciate all the work you and the team do on Vuetify! I'd love to contribute to the project, and submitted this PR. I'd love to get your thoughts when you have time. Thanks! |
{ class: 'v-date-picker-month__events' }, | ||
eventColors.map(color => { | ||
const { colorClasses, colorStyles } = useColor(toRef({ background: color })) | ||
return h('div', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a .TSX file so you should be able to just return a function that returns an element.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. I’ve updated the function to return an element directly. Let me know if any other changes are needed. Thanks!
I'll take a look. Is this mostly just copying what was there in V2? Also, since this is a feature, it will need to go to the Thank you! |
Thanks, John! Yes, this restores the event and event-color props in |
Description
VDatePicker
for month view.Fixes #19296
Markup: