Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

강의 겹칠 시 alert에서 displayMessage를 보여주도록 수정 #378

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

eastshine2741
Copy link
Collaborator

강의 겹쳤을 때 alert의 메시지로 displayMessage 쓰도록 바꿔야했는데 아직도 body.ext.confirm_message 쓰고있었다 [Slack]
dev에서 강의 겹쳤을 때 alert의 메시지가 비어있는 것 확인하고 수정
일단 prod에서는 문제 발생 안함

@eastshine2741 eastshine2741 requested a review from a team as a code owner November 16, 2024 09:56
@plgafhd
Copy link
Collaborator

plgafhd commented Nov 16, 2024

여기를 보니까 왜 그토록 ApiOnError를 쓰는걸 싫어하는지 알 것 같군...

@plgafhd plgafhd merged commit dffa142 into develop Jan 1, 2025
3 checks passed
@plgafhd plgafhd deleted the eastshine2741/fix-lecture-overlap-message branch January 1, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants