Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

강의계획서 pdf가 다운로드 되지 않는 현상 해결 #387

Merged
merged 1 commit into from
Jan 21, 2025
Merged

강의계획서 pdf가 다운로드 되지 않는 현상 해결 #387

merged 1 commit into from
Jan 21, 2025

Conversation

plgafhd
Copy link
Collaborator

@plgafhd plgafhd commented Jan 21, 2025 •
edited
Loading

  • WebView가 아닌, 이전처럼 브라우저 열도록 다시 변경
  • 이때, 곧 진행될 테마 마켓에서 추상화한 WebViewContainer를 쓸 것이기에, 그 형태는 건드리지 않고 SyllabusWebView(Container)만 삭제
  • 그러므로 강의평 또한 정상적으로 작동해야 함 (확인)
  • 또한, 테마 마켓과 WebView 관련 conflict이 나지 않도록 (이미 나고 있는 것 제외) 수정

@plgafhd plgafhd requested a review from a team as a code owner January 21, 2025 06:14
@plgafhd
Copy link
Collaborator Author

plgafhd commented Jan 21, 2025

그냥 revert commit 하기보다 설명에서 2~4에 초점 맞춰서 되돌려봤어..!

@plgafhd plgafhd changed the title 강의계획서 pdf가 열리지 않는 현상 해결 강의계획서 pdf가 다운로드 되지 않는 현상 해결 Jan 21, 2025
JuTaK97
JuTaK97 approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@JuTaK97 JuTaK97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿~

@JuTaK97
Copy link
Collaborator

JuTaK97 commented Jan 21, 2025

서버가 url은 바꿔준거지?

@plgafhd
Copy link
Collaborator Author

plgafhd commented Jan 21, 2025

오 맞아 서버에서 libproxy 붙은걸로 내려와

@plgafhd plgafhd merged commit ce08c11 into develop Jan 21, 2025
3 checks passed
@plgafhd plgafhd deleted the plgafhd/fix-syllabus-pdf branch January 21, 2025 15:26
plgafhd added a commit that referenced this pull request Jan 22, 2025
@plgafhd
강의계획서 pdf가 다운로드 되지 않는 현상 해결 (#387)
8c12693
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuTaK97 JuTaK97 JuTaK97 approved these changes

Assignees

@plgafhd plgafhd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plgafhd @JuTaK97