시간대 직접 선택 화면에서, 완료 버튼과 X 버튼이 겹치는 현상 해결 #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
원래 왼쪽 사진처럼 되고 있어서, 시간 선택 중일때만 X 버튼을 없앴어 
|
plgafhd
commented
Jan 24, 2025
.../java/com/wafflestudio/snutt2/views/logged_in/home/search/search_option/SearchOptionSheet.kt
Outdated
Show resolved
Hide resolved
|
이거 언제부터 이랬지? |
JuTaK97
reviewed
Jan 24, 2025
...om/wafflestudio/snutt2/views/logged_in/home/search/search_option/SearchOptionCancelButton.kt
Outdated
Show resolved
Hide resolved
|
ㅜㅜ.... 저땐 정말 몰랐는데.... |
This reverts commit 78a79ca.
plgafhd
commented
Jan 26, 2025
Comment on lines
174
to
180
| if (optionSheetMode != OptionSheetMode.TimeSelect) { | ||
| closeBottomSheetPlaceable.placeRelative( | ||
| tagTypePlaceable.width + tagListPlaceable.width - 52.dp.toPx().roundToInt(), | ||
| (SearchOptionSheetConstants.TopMargin.toPx().roundToInt() - 32.dp.toPx().roundToInt()) / 2, | ||
| ) | ||
| } | ||
| if (baseAnimatedFloat.value != 0f) dragSheetPlaceable.placeRelative(0, 0) |
There was a problem hiding this comment.
코드 구조를 이해하니 좀 더 좋은 방법을 찾아냈어
근데, L174의 반대인 optionSheetMode == OptionSheetMode.TimeSelect랑
L180의 baseAnimatedFloat.value != 0f랑 완벽히 동치인데,
별 이유 없으면 L180도 바꿀까...? 전자가 좀 더 의미 전달이 명확한듯 해서
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.