Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

같은 이름의 태그 선택 가능하도록 코드 개선 #396

Merged
merged 2 commits into from
Feb 15, 2025
Merged

같은 이름의 태그 선택 가능하도록 코드 개선 #396

merged 2 commits into from
Feb 15, 2025

Conversation

plgafhd
Copy link
Collaborator

@plgafhd plgafhd commented Feb 12, 2025

  • TagType는 다르지만 Tag 이름은 같은 경우가 생겨서, Tag.name과 TagType를 함께 LazyRow의 key로 넣어줌

@plgafhd plgafhd requested a review from a team as a code owner February 12, 2025 08:55
JuTaK97
JuTaK97 reviewed Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@JuTaK97 JuTaK97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data class TagDto 에 toString 을 정의해주는 건 어때

plgafhd
plgafhd commented Feb 13, 2025
View reviewed changes
app/src/main/java/com/wafflestudio/snutt2/model/TagDto.kt
Comment on lines +16 to +17

fun toItemKey(): String = type.toString() + name
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이렇게? 이게 더 나은 방법인건가
toString으로 겹치는 것보다는 별도 이름이 나을까 싶어서 이렇게 만들어놨어

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

override fun toString(): String = type.toString() + name

아예 이렇게 하는 걸 생각하긴 했는데 이게 더 좋을지도 ㅋㅋ 굳굳

@plgafhd plgafhd merged commit a8533cd into develop Feb 15, 2025
3 checks passed
@plgafhd plgafhd deleted the plgafhd/fix-same-tag branch February 15, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuTaK97 JuTaK97 JuTaK97 approved these changes

Assignees

@plgafhd plgafhd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plgafhd @JuTaK97