Add SitemapBuildableView #48
Conversation
> Invalid HTTP_HOST header: 'site_2'. The domain name provided is not valid according to RFC 1034/1035.
Based on WagtailBakeryView's request
|
Currently, sitemaps are build at the correct location for single and multisites, however the content is incorrect for multisites. Despite creating a request which is multisites aware, and that request being passed to the Sitemap object, it then use the paginator which doesn't seem to be multisite aware and return pages of the default site. There's I'll leave this aside for a bit so I can focus on releasing a new version of the package and then come back to this. |
There was a problem hiding this comment.
Thanks @loicteixeira, looks good!
We'll need some basic documentation, e.g. in the Configuration section of the README.
|
|
||
|
|
||
| class SitemapBuildableView(BuildableMixin): | ||
|
|
There was a problem hiding this comment.
Can we have a comment to explain the function of this view?
| view.request = view.create_request(view.sitemap_path) | ||
|
|
||
| content = view.get_content().decode() | ||
| expected_content = ( |
There was a problem hiding this comment.
This test looks fragile. Should we assume that the exact formatting of Django's sitemap generation will be consistent across versions? As an alternative we could parse the XML and check for the namespace, a single <loc> element inside a single <url> element etc.
Rebase & continue #38. Fix #37.