Add block previews #521
Open
Add block previews #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laymonage
commented
Jan 23, 2025
Comment on lines
+32
to
+36
| class CustomTypedTableBlock(TypedTableBlock): | ||
| def get_preview_value(self): | ||
| # Avoid having to construct TypedTable ourselves. This won't be | ||
| # necessary if https://github.com/wagtail/wagtail/pull/12808 is merged | ||
| return self.to_python(self.meta.preview_value) |
There was a problem hiding this comment.
Comment on lines
+1
to
+6
| {% extends "wagtailcore/shared/block_preview.html" %} | ||
| {% load static %} | ||
|
|
||
| {% block content %} | ||
| <img class="static-block-preview" src="{% static "img/embed-block-preview.png" %}" alt="Preview of an embedded video" /> | ||
| {% endblock %} |
There was a problem hiding this comment.
I thought it'd be nice to showcase how a static image preview could work with the current implementation.
laymonage
force-pushed
the
block-previews
branch
from
ef57d77 to
bce82c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some blocks are intentionally left out, to test the behaviour of blocks that do not have previews enabled.
Different approaches are simulated:
preview_value,descriptionvia init kwargsMetaget_preview_value()preview_templateto showcase using a static image for the previewI didn't find a use case for overriding
get_preview_context(), but let me know if we'd like to have it anyway.Screen.Recording.2025-01-23.at.16.57.41.mov
Screen.Recording.2025-01-23.at.16.58.56.mov