-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise Draftail integration UI #35
Revise Draftail integration UI #35
Conversation
Note: I thought I could resolve this by using the code below however it doesn't seem to work, so any ideas would be appreciated, otherwise I'll ignore it as it doesn't seem like a huge issue..
|
74a110d
to
2cd7a14
Compare
5f437e9
to
3866aab
Compare
9ba6677
to
9a0348f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! I'm not sure the flashing error message is a problem worth solving for now, but good to be aware of it.
…-draftail-api #11 - Update Draftail integration
9a0348f
to
e13e957
Compare
801bb13
into
feature/update-control-to-use-new-draftail-api
#16
Updates:
Background colour updates for loading overlay
Cancel request button
See screenshots for "Background colour updates to loading indicator"z-index bug
Resolves the issue below by applying a different z-index valueUpdating error messages
Errors related to the backend were not being handled correctly resulting in a JSON parse error (`“JSON.parse: unexpected character at line 1 column 1 of the JSON data”`) being sent to the front-end.Updates involved fixing this issue on the backend along with applying the correct classnames to match existing wagtail field panel errors.
reference of old error message
Updating the dropdown's background colour
I also experimented the excat same styling wagtail uses for drop downs which you can see on the branch `tmp/dropdown-stying` however since wagtail uses tippy.js to position and style the element, it doesn't seem like a valid approach.For testing error messages, I'd suggest either altering your API key to an invalid one or trying to run prompts on a field with no text/content.