Format unsaved entity file paths #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanhamlett
changed the title
alanhamlett
force-pushed
the
feature/format-windows
branch
from
ca3e5ed to
f75df94
Compare
alanhamlett
force-pushed
the
feature/format-windows
branch
2 times, most recently
from
8b715ce to
f100901
Compare
gandarez
force-pushed
the
feature/format-windows
branch
3 times, most recently
from
0e366a3 to
69b27a6
Compare
gandarez
force-pushed
the
feature/format-windows
branch
from
69b27a6 to
6f6d40e
Compare
alanhamlett
approved these changes
Jan 11, 2025
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## develop #1158 +/- ##
===========================================
- Coverage 62.99% 62.99% -0.01%
===========================================
Files 386 386
Lines 16914 16923 +9
===========================================
+ Hits 10655 10660 +5
- Misses 5686 5690 +4
Partials 573 573
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the validation of unsaved entity when formatting the entity filepath.