Only check configs for unique names if they declare properties #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StuartHarris
force-pushed
the
fix/validate-config-names
branch
from
89ddeb7 to
6aa6c7c
Compare
Signed-off-by: Stuart Harris <[email protected]>
StuartHarris
force-pushed
the
fix/validate-config-names
branch
from
6aa6c7c to
9e2630f
Compare
brooksmtownsend
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
#516 rejects manifests where multiple link configurations have the same name. This PR augments that functionality by only considering link configurations that declare properties. This is because (as currently implemented) configurations that don't declare properties can reference existing configs that are created either by
washor bywadm(prefixed by the application name, e.g. where application = "my-app" and config = "my-config", this can be referenced elsewhere in the manifest as "my_app-my_config").Related Issues
#516
#478
#401
Release Information
Manifests that were previously rejected may now be valid. As this widens rather than narrows, I suspect it can be released as a non-breaking minor/patch release.
Consumer Impact
All manifests that were previously valid should remain valid.
Testing
Unit Test(s)
Acceptance or Integration
The existing test case for validation of duplicate config names has been adjusted to include properties for the duplicate configs. Additionally, duplicate configs without properties were added to show that they are now allowed through the validation stage.
Manual Verification
None