Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deploying docs for clarity #310

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Update deploying docs for clarity #310

merged 2 commits into from
Oct 29, 2024

Conversation

vincanger
Copy link
Collaborator

Description

Fixes #275

Contributor Checklist

Make sure to do the following steps if they are applicable to your PR:

@vincanger vincanger requested a review from Martinsos October 24, 2024 10:38
Copy link
Member

@Martinsos Martinsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but left some small comments!


## Deploying your App
### Steps for Deploying Properly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, why Properly?


## Deploying your App
### Steps for Deploying Properly

These are the steps necessary for you to deploy your app properly. We recommend you follow these steps in order
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha also properly -> how would you deploy it otherwise :D?

These are the steps necessary for you to deploy your app properly. We recommend you follow these steps in order

- [ ] Get your [production API keys and environment variables](#prerequisites)
- [ ] [Deploy your app](#deploying-to-flyio)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also provide link for manual deployment if they want it? (Fly or Manual)?

@vincanger vincanger merged commit 255ea98 into main Oct 29, 2024
1 check passed
@vincanger vincanger deleted the improve-deployment-docs branch October 29, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve deployment docs (Stripe webhook, env vars)
2 participants