Sdk minor release 2024 #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #839 +/- ##
==========================================
- Coverage 89.82% 89.81% -0.01%
==========================================
Files 19 19
Lines 31987 32159 +172
==========================================
+ Hits 28732 28885 +153
- Misses 3255 3274 +19 ☔ View full report in Codecov by Sentry. |
jeff-arn
reviewed
Feb 26, 2024
Comment on lines
-2814
to
+3048
| sdk_headers = get_sdk_headers(service_name=self.DEFAULT_SERVICE_NAME, | ||
| service_version='V1', | ||
| operation_id='list_synonyms') | ||
| sdk_headers = get_sdk_headers( | ||
| service_name=self.DEFAULT_SERVICE_NAME, | ||
| service_version='V1', | ||
| operation_id='list_synonyms', | ||
| ) |
There was a problem hiding this comment.
It looks like the vast majority of these changes are indent changes. Is this an intentional stylistic change or did we forget to run a style linter?
There was a problem hiding this comment.
This is due to changes to updates to the sdk generator
BREAKING CHANGE: Name changes for multiple classes
apaparazzi0329
force-pushed
the
sdk-minor-release-2024
branch
from
c82d672 to
f982a82
Compare
jeff-arn
approved these changes
Feb 26, 2024
|
🎉 This PR is included in version 8.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.