Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Block Categories entity to Page Builder app #2390

Closed
wants to merge 6 commits into from
Closed

Add Block Categories entity to Page Builder app #2390

wants to merge 6 commits into from

Conversation

neatbyte-vnobis
Copy link
Collaborator

@neatbyte-vnobis neatbyte-vnobis commented May 9, 2022 •
edited
Loading

Changes

Block Categories are added to Page Builder application.
Changes covers DB, API and APP packaged related to Page Builder application.

How Has This Been Tested?

Local testing; API sandbox testing;

Documentation

Pull request with updated Docs: webiny/docs.webiny.com#476

@SvenAlHamad SvenAlHamad requested review from Pavel910 and adrians5j May 10, 2022 11:12
@adrians5j adrians5j requested a review from brunozoric May 13, 2022 08:02
@brunozoric
Copy link
Contributor

hi @neatbyte-vnobis
Everything seems fine both code wise and the UI. Only bug I found is that you can input anything into the slug of the Block Category. I would allow only a-z and -. Basically, lower kebab-case.

brunozoric
brunozoric approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@brunozoric brunozoric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems ok now. Thanks :)

@brunozoric brunozoric added this to the 5.27.0 milestone May 25, 2022
@neatbyte-vnobis
Copy link
Collaborator Author

Closing this pull as code changes were moved under umbrella pull #2448

@neatbyte-vnobis neatbyte-vnobis deleted the blockCategories branch November 22, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunozoric brunozoric brunozoric approved these changes

@Pavel910 Pavel910 Awaiting requested review from Pavel910

@adrians5j adrians5j Awaiting requested review from adrians5j

Assignees

@brunozoric brunozoric

Labels
feature
Projects
None yet
Milestone
5.27.0
Development

Successfully merging this pull request may close these issues.
2 participants
@neatbyte-vnobis @brunozoric