-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new merge #221
Open
Lostinaa
wants to merge
70
commits into
2018
Choose a base branch
from
master
base: 2018
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+81,747
−34,259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few suggested changes to make the meaning clearer.
Cleaned up language in the To Start section
Fixed small typo
updated firebase to 4.10.1
Updated package versions to fix vulnerability issues
using `this.myInput.value` gives undefined.
Change "current.value" to use new ref syntax
change all instances of "value.value"
I've seen quite a few people run into this issue in the Slack channel, myself included. You go over this in the Apache deploy video, but most people will try interacting with their app in the Netlify or Now deploy videos and think it's broken.
add Firebase warning FAQ
Added some missing prop-types
Update StorePicker.js
Updated ReadMe note covering dependencies
Update styles:watch command to use -- to prevent duplication
Removing incompatible browerslist flag
Feature/update now config
Add sans-serif fallback to button and input styles
Styling for total in order col
Update react-scripts to `3.4.1`
Add missing propTypes property (deleteFish).
Add missing propTypes property (deleteFish)
Update starter and finished app npm packages
add missing images route for vercel deployments
create npmrc file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge