Make FlowUtils (and Flowkit) compatible with NumPy >= 2.0 #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
FlowUtils (and therefore Flowkit) are blocked to (at best) numpy=1.26 because of the change in its C API. This PR updates the package to ensure compatibility with NumPy version 2.0 and above.
What changes have been made?.
In both _logicle.c and gate_helpers.c :
In the setup files:
-> This new version must be compiled with numpy>=2.x, but the python can be used with older versions of numpy (at least 1.26 works for me).
Breaking changes
The package now requires NumPy >= 2.0 to compile the C files. Older versions are no longer supported.
How was this tested?
I use run_test.py, no changes where made in the unit tests.
Bonus
In gate_helpers.c you mention that the algorithm you use for points_in_polygon is based on a website. But this website now seems to be a scam.