Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for triangular bounding boxes #5

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

vhf
Copy link
Contributor

@vhf vhf commented Dec 3, 2020

Here's a fix for one of the two bugs described in #4 .

I haven't yet found a fix for zero area bounding boxes.

@Jdyn
Copy link

Jdyn commented Dec 11, 2023

Any chance of merging this? I have been encountering this as well.

I have also encountered the crash from inserting zero area bounding boxes as well, but it was by error. That is, I didn't actually mean to insert zero area, but for example if the input is user generated, it was possible. Of course you could create a check before feeding it to insert but I wonder if the library could take care of that check? Is there any use case to insert a zero area box besides by accident?

@vhf do you still use this library? I noticed that if you call functions like insert and the key is already there, it still returns :ok even though the operation was not successful. Say if the key was already in the tree, you wanted to update it instead, a.k.a upsert, it doesn't seem straight foward to do since it always returns :ok. Do you think updating the library to return responses like {:already_exists, nil} will improve the library?

@vhf
Copy link
Contributor Author

vhf commented Dec 12, 2023

@vhf do you still use this library?

I don't. I can confirm this PR works though, I used it for a couple of years. The studio behind this lib hasn't been active the past 3 years, if I still needed this lib I'd try to get access to the repo and package from the original maintainers.

@sikanrong sikanrong merged commit 4f6aa4b into windfish-studio:master Dec 12, 2023
@sikanrong
Copy link
Contributor

@Jdyn this project is unmaintained but I merged this PR. Didn't test it but the code makes sense / seems fine to me

@vhf vhf deleted the triangular-bug branch December 12, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants