Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkpoint deposit and global reward in alterClaimer and alterDelegatee #83

Closed
alexkeating opened this issue Dec 11, 2024 · 1 comment · Fixed by #88
Closed

Checkpoint deposit and global reward in alterClaimer and alterDelegatee #83

alexkeating opened this issue Dec 11, 2024 · 1 comment · Fixed by #88
Assignees
@alexkeating
Labels
post-audit

Comments

@alexkeating
Copy link
Collaborator

Description

  • Add test based to verify shares are not inflated
  • Add something like below
  function _alterClaimer(
    Deposit storage deposit,
    DepositIdentifier _depositId,
    address _newClaimer
  ) internal virtual {
    _revertIfAddressZero(_newClaimer);

+   _checkpointGlobalReward();
+   _checkpointReward(deposit);
@alexkeating
Copy link
Collaborator Author

sherlock-audit/2024-11-tally#31

@alexkeating alexkeating self-assigned this Dec 12, 2024
@alexkeating alexkeating mentioned this issue Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexkeating alexkeating

Labels
post-audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add checkpointing in missing methods withtally/staker
1 participant
@alexkeating