Add checkpointing in missing methods #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildmolasses
approved these changes
Dec 13, 2024
test/GovernanceStaker.t.sol
Outdated
| @@ -2764,6 +2764,58 @@ contract NotifyRewardAmount is GovernanceStakerRewardsTest { | |||
| assertLe(govStaker.scaledRewardRate(), _expectedRewardRate); | |||
| } | |||
|
|
|||
| function test_shareManipulationIfRewardsArentCeckpointed() public { | |||
There was a problem hiding this comment.
Suggested change
| function test_shareManipulationIfRewardsArentCeckpointed() public { | |
| function test_shareManipulationIfRewardsArentCheckpointed() public { |
There was a problem hiding this comment.
should we rename this test to describe that there's no longer share manipulation? also, are there unit tests to write here (e.g. alterDelegatee checkpoints global reward, alterDelegatee checkpoints reward)? defer to you on that
test/GovernanceStaker.t.sol
Outdated
|
|
||
| address _fox = makeAddr("fox"); | ||
|
|
||
| //!audit-ok Step 1, fox deposits with full earning power |
There was a problem hiding this comment.
might revise these comments, or possibly attribute CergyK above the test
alexkeating
force-pushed
the
fix/earning-power-inflation
branch
from
b63e68c to
e3592d4
Compare
|
Coverage after merging fix/earning-power-inflation into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #83