Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ui): avoid store class instances in vuex #1826

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor(ui): avoid store class instances in vuex #1826

wants to merge 1 commit into from

Conversation

Tommytrg
Copy link
Member

@Tommytrg Tommytrg commented Nov 8, 2022

No description provided.

@Tommytrg Tommytrg force-pushed the remove-classes-state branch from ef79b4a to 31dd173 Compare November 8, 2022 18:52
@Tommytrg
refactor(ui): avoid store class instances in vuex
a3cbb52 
We should only store plain objects in vuex to avoid not being able to call the class instance methods
@Tommytrg Tommytrg force-pushed the remove-classes-state branch from 31dd173 to a3cbb52 Compare November 8, 2022 18:57
@Tommytrg Tommytrg requested a review from gabaldon November 8, 2022 18:58
gabaldon
gabaldon requested changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@gabaldon gabaldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also update context.rootState.wallet.api.getItem and context.rootState.wallet.api.saveItem in rad.js. The wallet api is not anymore in wallet.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabaldon gabaldon gabaldon requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tommytrg @gabaldon