Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add selection validation support #3497

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add selection validation support #3497

wants to merge 1 commit into from

Conversation

adids1221
Copy link
Contributor

@adids1221 adids1221 commented Feb 4, 2025 •
edited
Loading

Description

Picker Dialog validation feature (supported only in the new Dialog).
New UsePickerDialogProps hook to determine the default props of the dialog instead of the index file.
UsePickerSelection hook handles the validation and trigger the selectionValidation function.
Also in this PR there is a fix, Picker Dialog shouldn't render Modal.TopBar (at least when the user pass migrateDialog).
(old PR #3242)

Changelog

Picker Dialog validation feature.

Additional info

MADS-4430

@adids1221 adids1221 requested a review from M-i-k-e-l February 4, 2025 14:49
M-i-k-e-l
M-i-k-e-l reviewed Feb 6, 2025
View reviewed changes
Copy link
Contributor

@M-i-k-e-l M-i-k-e-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why this feature is only for Dialog.
Maybe shouldDisableDoneButton should be shouldDisableSelection?

@M-i-k-e-l
Copy link
Contributor

Lets separate the Modal.TopBar fix to another PR, even if it's very small.

@M-i-k-e-l M-i-k-e-l assigned adids1221 and unassigned M-i-k-e-l Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M-i-k-e-l M-i-k-e-l M-i-k-e-l left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@adids1221 adids1221

Labels
waiting-for-response
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adids1221 @M-i-k-e-l