Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(slider): simplify hitSlop implementation #3527

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Description

Simplify hitSlop implementation in both Slider components by using a number instead of an object when all directions are equal, following React Native's pattern and maintaining 48x48 hit target size.

Changelog

Slider/Incubator.Slider - Simplified hitSlop implementation while maintaining 48x48 hit target

Details

  • Using number for hitSlop is simpler and follows React Native's pattern
  • 12 pixels on each side maintains 48x48 hit target (24 + 12 + 12)
  • No changes needed to z-index/touch priority as it's already handled correctly
  • Tests verify the simplified hitSlop implementation
  • Changes are backward compatible since React Native supports both forms

Link to Devin run: https://app.devin.ai/sessions/fc2cb153860345108b58985f0b922733

Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants