Add Apple to list of providers. (#323)

* user_management: add Apple to list of providers. This may be me completely understanding this code but: this looked like an omission here so I thought I'd open a PR for discussion. * types/provider: add another missing Apple addition. * Fix specs * Fix Rubocop offense --------- Co-authored-by: Michael Hadley <[email protected]>
workos · Aug 9, 2024 · ef7c82d · ef7c82d
1 parent 840c795
commit ef7c82d
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/lib/workos/types/provider.rb b/lib/workos/types/provider.rb
@@ -10,7 +10,7 @@ module Provider
       Google = 'GoogleOAuth'
       Microsoft = 'MicrosoftOAuth'
 
-      ALL = [GitHub, Google, Microsoft].freeze
+      ALL = [Apple, GitHub, Google, Microsoft].freeze
     end
   end
 end
diff --git a/lib/workos/user_management.rb b/lib/workos/user_management.rb
@@ -19,7 +19,7 @@ class Provider
         Microsoft = 'MicrosoftOAuth'
         AuthKit = 'authkit'
 
-        ALL = [GitHub, Google, Microsoft, AuthKit].freeze
+        ALL = [Apple, GitHub, Google, Microsoft, AuthKit].freeze
       end
 
       # The AuthFactorType is a declaration of a

diff --git a/spec/lib/workos/sso_spec.rb b/spec/lib/workos/sso_spec.rb
@@ -281,7 +281,8 @@
           described_class.authorization_url(**args)
         end.to raise_error(
           ArgumentError,
-          'Okta is not a valid value. `provider` must be in ["GitHubOAuth", "GoogleOAuth", "MicrosoftOAuth"]',
+          'Okta is not a valid value. `provider` must be in ' \
+          '["AppleOAuth", "GitHubOAuth", "GoogleOAuth", "MicrosoftOAuth"]',
         )
       end
     end

diff --git a/spec/lib/workos/user_management_spec.rb b/spec/lib/workos/user_management_spec.rb
@@ -213,7 +213,7 @@
         end.to raise_error(
           ArgumentError,
           'Okta is not a valid value. `provider` must be in ' \
-          '["GitHubOAuth", "GoogleOAuth", "MicrosoftOAuth", "authkit"]',
+          '["AppleOAuth", "GitHubOAuth", "GoogleOAuth", "MicrosoftOAuth", "authkit"]',
         )
       end
     end