Bump minimum required Ruby version to 3.1 #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous minimum was 2.7, which was end-of-life (EOL) 2023-03-31. 3.0 was EOL 2024-04-23 ([source][]). [source]: https://www.ruby-lang.org/en/downloads/branches/
dandorman
force-pushed
the
fix/bump-minimum-ruby-version
branch
from
1ca5a6b to
595479e
Compare
nicknisi
approved these changes
Jan 22, 2025
nicknisi
approved these changes
Jan 22, 2025
mthadley
approved these changes
Jan 22, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previous minimum was 2.7, which was end-of-life (EOL) 2023-03-31. 3.0 was EOL 2024-04-23 (source).
I'm also bumping Rubocop, mostly to get to a version that recognized Ruby 3.1. Rather than address all of those style changes in this PR, I've added an auto-generated
.rubocop_todo.ymlto track required changes. I initially tried it at the earliest version that had 3.1 in it (I think v1.14.0?), but the lift between that and the latest version seemed roughly the same, so I figured I'd buy us some runway.Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.