-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement network-specific metadata handling in commands. #518
base: main
Are you sure you want to change the base?
Conversation
Added overrides for add, update, get, and delete metadata methods to utilize network-specific options when available. This ensures compatibility and functionality for multisite network scenarios. Fallbacks to standard metadata functions are maintained for non-network environments.
Pinging maintainers to get eyes on this @swissspidy @danielbachhuber @schlessera |
Note that we get pinged automatically with the review request :) |
Two thoughts:
|
No one was assigned for a code reviewers. Maybe this repo needs a codeowner file 🤔
Before spending any time on getting tests to work, I wanted to make sure everyone was happy with the approach.
The core patch is not confirmed yet and not work. Also that will only fix the issue with 6.8+. WP CLI support down to 3.7. Fixing this here is to ensure BC. |
Yes, approach looks good, @jonnynews. If we add the tests from #504 , this will be good to go. |
Added overrides for add, update, get, and delete metadata methods to utilize network-specific options when available. This ensures compatibility and functionality for multisite network scenarios. Fallbacks to standard metadata functions are maintained for non-network environments.
Add function exists, to ensure compatablity with 4.2 below.
Fixes #504