Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a small text to understand that the links only work for WP-CLI organization team #505

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added a small text to understand that the links only work for WP-CLI organization team #505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion committers-credo.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ Some people have write access to WP-CLI repositories. These people are identifie

* [maintainers](https://github.com/orgs/wp-cli/teams/maintainers) - Project leadership
* [committers](https://github.com/orgs/wp-cli/teams/committers) - Trusted contributors

The above links are not public; they only work for GitHub users who are part of the WP-CLI GitHub organization.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schlessera @danielbachhuber @swissspidy I'm uncertain about whether these teams should be visible to the public. If they should be, we'll need to adjust their visibility settings, as outlined here: https://docs.github.com/en/organizations/organizing-members-into-teams/changing-team-visibility.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are already visible. The problem is even visible teams are only visible to organization members, not the general public. Teams cannot be made publicly visible. That's also what that documentation says.

Given that this page is for committers and committers are part of the GitHub org anyway, I don't really see an issue with that though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, huh. I always thought they were publicly accessible. That was the original intent — to provide visibility into who makes decisions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Committers and maintainers links are used in several other pages also, like governance, code review, etc. It would be nice thing to be able to view who are maintaining the project by non-team members also.

Copy link
Member

@BrianHenryIE BrianHenryIE Jul 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"People" shows nine members without being logged in to GitHub, thirteen when I'm logged in.

https://github.com/orgs/wp-cli/people


This “Committers credo” is a living document. It’s meant to establish generally agreed upon standards for committers, and will continue to evolve over time.

Expand Down Expand Up @@ -41,5 +43,5 @@ Committer participation isn’t just committing code. Often, you can have a huge

* Refining an existing piece of documentation, or drafting a new one.
* Helping a contributor with whatever is needed to finish up their pull request.
* If a contributor abandons a pull request (e.g. no activity in two weeks) that's close to a mergeable state, you can [perform any necessary cleanup by committing directly to their branch](https://help.github.com/articles/committing-changes-to-a-pull-request-branch-created-from-a-fork/) and get it over the finish line.
* If a contributor abandons a pull request (e.g., no activity in two weeks) that's close to a mergeable state, you can [perform any necessary cleanup by committing directly to their branch](https://help.github.com/articles/committing-changes-to-a-pull-request-branch-created-from-a-fork/) and get it over the finish line.
* Triaging issues by spending 5-10 minutes further diagnosing the report and commenting with additional information you’ve discovered.