remove soci includes from macros prewenting warnings

wsekta · Feb 1, 2024 · a3f4be4 · a3f4be4
1 parent 55eed80
commit a3f4be4
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 13 deletions.
diff --git a/include/orm-cxx/database/binding/Binding.hpp b/include/orm-cxx/database/binding/Binding.hpp
@@ -5,15 +5,12 @@
 #include "ObjectFieldToValues.hpp"
 #include "orm-cxx/utils//ConstexprFor.hpp"
 #include "orm-cxx/utils/DisableExternalsWarning.hpp"
+#include "soci/type-conversion.h"
+#include "soci/values.h"
 
 DISABLE_WARNING_PUSH
-
 DISABLE_EXTERNAL_WARNINGS
-
 #include "rfl/to_view.hpp"
-#include "soci/type-conversion.h"
-#include "soci/values.h"
-
 DISABLE_WARNING_POP
 
 namespace soci

diff --git a/include/orm-cxx/database/binding/ObjectFieldFromValues.hpp b/include/orm-cxx/database/binding/ObjectFieldFromValues.hpp
@@ -3,11 +3,7 @@
 #include "BindingPayload.hpp"
 #include "orm-cxx/utils/ConstexprFor.hpp"
 #include "orm-cxx/utils/DisableExternalsWarning.hpp"
-
-DISABLE_WARNING_PUSH
-DISABLE_EXTERNAL_WARNINGS
 #include "soci/values.h"
-DISABLE_WARNING_POP
 
 namespace orm::db::binding
 {

diff --git a/include/orm-cxx/database/binding/ObjectFieldToValues.hpp b/include/orm-cxx/database/binding/ObjectFieldToValues.hpp
@@ -3,11 +3,7 @@
 #include "BindingPayload.hpp"
 #include "orm-cxx/utils/ConstexprFor.hpp"
 #include "orm-cxx/utils/DisableExternalsWarning.hpp"
-
-DISABLE_WARNING_PUSH
-DISABLE_EXTERNAL_WARNINGS
 #include "soci/values.h"
-DISABLE_WARNING_POP
 
 namespace orm::db::binding
 {