fix: drop to 3 nodes, respond to comments

docker-compose.yml

@@ -243,6 +243,7 @@ services:
     profiles:
       - dev
 
+#  3 node minimum for a cluster, per redis documentation
   redis-cluster-node-0:
     image: redis:${DC_REDIS_VERSION:-7.2.4}-alpine
     command: redis-server /usr/local/etc/redis/redis.conf
@@ -279,42 +280,6 @@ services:
     profiles:
       - dev
 
-  redis-cluster-node-3:
-    image: redis:${DC_REDIS_VERSION:-7.2.4}-alpine
-    command: redis-server /usr/local/etc/redis/redis.conf
-    networks:
-      - primary
-    ports:
-      - "7003:6379"
-    volumes:
-      - ./docker/redis/redis-cluster.conf:/usr/local/etc/redis/redis.conf
-    profiles:
-      - dev
-
-  redis-cluster-node-4:
-    image: redis:${DC_REDIS_VERSION:-7.2.4}-alpine
-    command: redis-server /usr/local/etc/redis/redis.conf
-    networks:
-      - primary
-    ports:
-      - "7004:6379"
-    volumes:
-      - ./docker/redis/redis-cluster.conf:/usr/local/etc/redis/redis.conf
-    profiles:
-      - dev
-
-  redis-cluster-node-5:
-    image: redis:${DC_REDIS_VERSION:-7.2.4}-alpine
-    command: redis-server /usr/local/etc/redis/redis.conf
-    networks:
-      - primary
-    ports:
-      - "7005:6379"
-    volumes:
-      - ./docker/redis/redis-cluster.conf:/usr/local/etc/redis/redis.conf
-    profiles:
-      - dev
-
   redis-cluster-configure:
     image: redis:${DC_REDIS_VERSION:-7.2.4}-alpine
     command: /usr/local/etc/redis/redis-cluster-create.sh
@@ -324,9 +289,6 @@ services:
       - redis-cluster-node-0
       - redis-cluster-node-1
       - redis-cluster-node-2
-      - redis-cluster-node-3
-      - redis-cluster-node-4
-      - redis-cluster-node-5
     volumes:
       - ./docker/redis/:/usr/local/etc/redis/
 
@@ -370,6 +332,3 @@ volumes:
   redis-cluster-node-0:
   redis-cluster-node-1:
   redis-cluster-node-2:
-  redis-cluster-node-3:
-  redis-cluster-node-4:
-  redis-cluster-node-5:

docker/redis/redis-cluster-create.sh

@@ -4,16 +4,10 @@ sleep 10
 node_0_ip=$(getent hosts redis-cluster-node-0 | awk '{ print $1 }')
 node_1_ip=$(getent hosts redis-cluster-node-1 | awk '{ print $1 }')
 node_2_ip=$(getent hosts redis-cluster-node-2 | awk '{ print $1 }')
-node_3_ip=$(getent hosts redis-cluster-node-3 | awk '{ print $1 }')
-node_4_ip=$(getent hosts redis-cluster-node-4 | awk '{ print $1 }')
-node_5_ip=$(getent hosts redis-cluster-node-5 | awk '{ print $1 }')
 
 
 redis-cli --cluster create \
   $node_0_ip:6379 \
   $node_1_ip:6379 \
   $node_2_ip:6379 \
-  $node_3_ip:6379 \
-  $node_4_ip:6379 \
-  $node_5_ip:6379 \
-  --cluster-replicas 1 --cluster-yes
+  --cluster-replicas 0 --cluster-yes

docker/redis/redis-cluster.conf

@@ -2,7 +2,7 @@ cluster-enabled yes
 cluster-config-file nodes.conf
 cluster-node-timeout 5000
 bind 0.0.0.0
-protected-mode n
+protected-mode no
 maxmemory 100mb
 maxmemory-policy noeviction
 save 60 1

router/internal/persistedoperation/operationstorage/redis/rdcloser.go

@@ -5,12 +5,15 @@ import (
 	"fmt"
 	"github.com/redis/go-redis/v9"
 	"go.uber.org/zap"
+	"io"
 	"strings"
 )
 
+// RDCloser is an interface that combines the redis.Cmdable and io.Closer interfaces, ensuring that we can close the
+// client connection.
 type RDCloser interface {
 	redis.Cmdable
-	Close() error
+	io.Closer
 }
 
 type RedisCloserOptions struct {
@@ -24,7 +27,7 @@ func NewRedisCloser(opts *RedisCloserOptions) (RDCloser, error) {
 	if !strings.Contains(opts.URL, ",") {
 		options, err := redis.ParseURL(opts.URL)
 		if err != nil {
-			return nil, fmt.Errorf("failed to parse the redis connection url %s: %w", opts.URL, err)
+			return nil, fmt.Errorf("failed to parse the redis connection url: %w", err)
 		}
 
 		if opts.Password != "" {
@@ -41,7 +44,7 @@ func NewRedisCloser(opts *RedisCloserOptions) (RDCloser, error) {
 			Password: opts.Password,
 		})
 		if !isFunctioningClient(rdb) {
-			return rdb, fmt.Errorf("failed to create a functioning redis client. Ensure that you have provided multiple cluster URLs for a cluster client")
+			return rdb, fmt.Errorf("failed to create a functioning redis client")
 		}
 	}