Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: subgraph timeout can't be bigger than global timeout #1548

Merged
merged 6 commits into from
Jan 31, 2025
Merged

fix: subgraph timeout can't be bigger than global timeout #1548

merged 6 commits into from
Jan 31, 2025
+103 −40

Conversation

devsergiy
Copy link
Member

Motivation and Context

Checklist

  • I have discussed my proposed changes in an issue and have received approval to proceed.
  • I have followed the coding standards of the project.
  • Tests or benchmarks have been added or updated.
  • Documentation has been updated on https://github.com/wundergraph/cosmo-docs.
  • I have read the Contributors Guide.

@devsergiy devsergiy requested a review from StarpTech January 30, 2025 16:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2025 •
edited
Loading

Router image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-055a9c6ead8fc3b2c4243346f394f4f8aec21beb

@devsergiy devsergiy force-pushed the sergiy/eng-6342-timeouts-per-subgraph branch from e3902c5 to 630cefb Compare January 30, 2025 16:13
@devsergiy devsergiy requested a review from StarpTech January 30, 2025 19:08
StarpTech
StarpTech approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devsergiy devsergiy merged commit 92b69a3 into main Jan 31, 2025
13 checks passed
@devsergiy devsergiy deleted the sergiy/eng-6342-timeouts-per-subgraph branch January 31, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StarpTech StarpTech StarpTech approved these changes

@alepane21 alepane21 alepane21 approved these changes

Assignees
No one assigned
Labels
router
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devsergiy @alepane21 @StarpTech