Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use subgraphId while performing operations check #1581

Merged
merged 5 commits into from
Feb 12, 2025
Merged

fix: use subgraphId while performing operations check #1581

merged 5 commits into from
Feb 12, 2025

Conversation

JivusAyrus
Copy link
Member

This pr adds the subgraph id to the filter while fetching the affected operations during subgraph check.

Checklist

  • I have discussed my proposed changes in an issue and have received approval to proceed.
  • I have followed the coding standards of the project.
  • Tests or benchmarks have been added or updated.
  • Documentation has been updated on https://github.com/wundergraph/cosmo-docs.
  • I have read the Contributors Guide.

StarpTech
StarpTech approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JivusAyrus JivusAyrus merged commit 473d4da into main Feb 12, 2025
8 checks passed
@JivusAyrus JivusAyrus deleted the suvij/eng-6393-diff-between-subgraph-schemas-during-checks-cause-wrong-1 branch February 12, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StarpTech StarpTech StarpTech approved these changes

Assignees
No one assigned
Labels
controlplane
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JivusAyrus @StarpTech