Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if label matchers have changed before composing #1589

Merged
merged 5 commits into from
Feb 12, 2025

Conversation

thisisnithin
Copy link
Member

@thisisnithin thisisnithin commented Feb 12, 2025

Motivation and Context

Fixes unnecessary compositions when the federated graph label matchers remain unchanged.

Fixes ENG-6270

Checklist

  • I have discussed my proposed changes in an issue and have received approval to proceed.
  • I have followed the coding standards of the project.
  • Tests or benchmarks have been added or updated.
  • Documentation has been updated on https://github.com/wundergraph/cosmo-docs.
  • I have read the Contributors Guide.

Copy link
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thisisnithin thisisnithin enabled auto-merge (squash) February 12, 2025 16:27
@thisisnithin thisisnithin merged commit ead469c into main Feb 12, 2025
8 checks passed
@thisisnithin thisisnithin deleted the nithin/eng-6270-attempt-2 branch February 12, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants