[net10.0] [dotnet] Disable aggressive attribute trimming when using NativeAOT. Fixes #22065. #22151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ativeAOT. Fixes #22065. Aggressive attribute trimming removes attributes used by the trimmer. This is fine as long as we don't run _two_ trimmers - because then the first pass would remove attributes needed by the second pass, which is exactly what happens when we're building using NativeAOT: we first run ILLink, then NativeAOT's trimmer. If aggressive attribute trimming is enabled in this scenario, ILLink will remove attributes required by NativeAOT to work correctly, so disable aggressive attribute trimming. Fixes #22065.
🔥 [PR Build] Build failed (Build macOS tests) 🔥Build failed for the job 'Build macOS tests' (with job status 'Failed') Pipeline on Agent |
🔥 [PR Build] Build failed (Build packages) 🔥Build failed for the job 'Build packages' (with job status 'Failed') Pipeline on Agent |
🔥 [PR Build] Build failed (Detect API changes) 🔥Build failed for the job 'Detect API changes' (with job status 'Failed') Pipeline on Agent |
dalexsoto
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aggressive attribute trimming removes attributes used by the trimmer. This is
fine as long as we don't run two trimmers - because then the first pass
would remove attributes needed by the second pass, which is exactly what
happens when we're building using NativeAOT: we first run ILLink, then
NativeAOT's trimmer.
If aggressive attribute trimming is enabled in this scenario, ILLink will
remove attributes required by NativeAOT to work correctly, so disable
aggressive attribute trimming.
Fixes #22065.