Revert "backend: (x86) Fix register sets test coverage (#3866)" (#3890)

This reverts commit 8863a69.

tests/dialects/test_x86.py

@@ -3,20 +3,6 @@
 from xdsl.dialects import x86
 
 
-def test_unallocated_register():
-    unallocated = x86.register.GeneralRegisterType("")
-    assert not unallocated.is_allocated
-    assert unallocated == x86.register.GeneralRegisterType.unallocated()
-
-    unallocated = x86.register.RFLAGSRegisterType("")
-    assert not unallocated.is_allocated
-    assert unallocated == x86.register.RFLAGSRegisterType.unallocated()
-
-    unallocated = x86.register.AVXRegisterType("")
-    assert not unallocated.is_allocated
-    assert unallocated == x86.register.AVXRegisterType.unallocated()
-
-
 @pytest.mark.parametrize(
     "register, name",
     [
@@ -42,8 +28,6 @@ def test_register(register: x86.register.GeneralRegisterType, name: str):
     assert register.is_allocated
     assert register.register_name == name
 
-    assert register.instruction_set_name() == "x86"
-
 
 def test_rflags_register():
     rflags = x86.register.RFLAGS
@@ -143,5 +127,3 @@ def test_avx2_register(register: x86.register.AVX2RegisterType, name: str):
 def test_sse_register(register: x86.register.SSERegisterType, name: str):
     assert register.is_allocated
     assert register.register_name == name
-
-    assert register.instruction_set_name() == "x86AVX"

xdsl/dialects/x86/register.py

@@ -22,13 +22,15 @@ def parse_parameters(cls, parser: AttrParser) -> Sequence[Attribute]:
         if parser.parse_optional_punctuation("<") is not None:
             name = parser.parse_identifier()
             parser.parse_punctuation(">")
+            if not name.startswith("e") and not name.startswith("r"):
+                assert name in cls.abi_index_by_name(), f"{name}"
         else:
             name = ""
         return cls._parameters_from_spelling(name)
 
     def verify(self) -> None:
         name = self.spelling.data
-        if not self.is_allocated:
+        if not self.is_allocated or name.startswith("e") or name.startswith("r"):
             return
         if name not in type(self).abi_index_by_name():
             raise VerifyException(f"{name} not in {self.instruction_set_name()}")

xdsl/tools/command_line_tool.py

@@ -8,7 +8,7 @@
 from xdsl.dialects import get_all_dialects
 from xdsl.dialects.builtin import ModuleOp
 from xdsl.parser import Parser
-from xdsl.utils.exceptions import DiagnosticException, ParseError
+from xdsl.utils.exceptions import ParseError
 from xdsl.utils.lexer import Span
 
 
@@ -117,10 +117,5 @@ def parse_chunk(
                 print(e)
             else:
                 raise
-        except DiagnosticException as e:
-            if self.args.verify_diagnostics:
-                print(e)
-            else:
-                raise
         finally:
             chunk.close()