core: Add support for typed SSA values in isa #3988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`isa(arg, SSAValue[T])` will check that `arg` is an SSA value, and that its type is `T`. stack-info: PR: #3988, branch: math-fehr/stack/3
math-fehr
force-pushed
the
math-fehr/stack/3
branch
from
94c3082 to
df1b555
Compare
math-fehr
force-pushed
the
math-fehr/stack/2
branch
from
43a5756 to
1c59e49
Compare
This was referenced Feb 28, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## math-fehr/stack/2 #3988 +/- ##
=====================================================
+ Coverage 89.99% 90.16% +0.17%
=====================================================
Files 466 458 -8
Lines 59260 58315 -945
Branches 5800 5693 -107
=====================================================
- Hits 53330 52581 -749
+ Misses 4500 4341 -159
+ Partials 1430 1393 -37 ☔ View full report in Codecov by Sentry. |
alexarice
approved these changes
Feb 28, 2025
| if origin is SSAValue: | ||
| if not isinstance(arg, SSAValue): | ||
| return False | ||
| arg = cast(SSAValue, arg) |
There was a problem hiding this comment.
Would it make sense to do isa(arg.type, get_args(hint)[0]) here?
|
|
||
| assert isa(a, SSAValue) | ||
| assert isa(a, SSAValue[IntegerType]) | ||
| assert not isa(a, SSAValue[StringAttr]) |
There was a problem hiding this comment.
Could we have a test with a generic attribute like VectorType[IntegerType] or something.
math-fehr
force-pushed
the
math-fehr/stack/2
branch
from
1c59e49 to
1f5d2be
Compare
math-fehr
force-pushed
the
math-fehr/stack/3
branch
from
df1b555 to
d825f9f
Compare
math-fehr
added a commit
that referenced
this pull request
Feb 28, 2025
`isa(arg, SSAValue[T])` will check that `arg` is an SSA value, and that its type is `T`. stack-info: PR: #3988, branch: math-fehr/stack/3
compor
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
core: Add support for typed SSA values in isa
isa(arg, SSAValue[T])will check thatargis an SSA value, and thatits type is
T.