Skip to content

Commit

Permalink
updated Code Review comments
Browse files Browse the repository at this point in the history
fixed as per @hugovk comments
  • Loading branch information
kamleshkc2002 authored and simeg committed Jul 6, 2020
1 parent e7a2847 commit deaa330
Show file tree
Hide file tree
Showing 18 changed files with 68 additions and 68 deletions.
2 changes: 1 addition & 1 deletion .github/CONTRIBUTION_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
How to install it. If it's available on Homebrew, just include the following:
```sh
$ brew install <tool>
brew install <tool>
```
-->

Expand Down
2 changes: 1 addition & 1 deletion BashCompletion/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ source ~/.bash_profile
Once you've done this, you can use bash completion by pressing the tab key
twice after a command. For example:

```sh
```console
$ git [tab] [tab]
add blame cherry-pick config format-patch gui merge push repack rm stage whatchanged
am branch citool describe fsck help mergetool range-diff replace send-email stash worktree
Expand Down
8 changes: 4 additions & 4 deletions Git/gitignore.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ to not track files that are almost always ignored in all Git repositories.

Or simply download [macOS specific .gitignore](https://github.com/github/gitignore/blob/master/Global/macOS.gitignore) maintained by GitHub itself and put contents of it to `~/.gitignore`.

>**Note**: You can also download it using curl
* You can also use a default gitignore using Curl

>```sh
>curl https://raw.githubusercontent.com/github/gitignore/master/Global/macOS.gitignore -o ~/.gitignore
>```
```sh
curl https://raw.githubusercontent.com/github/gitignore/master/Global/macOS.gitignore -o ~/.gitignore
```

## Generate gitignore

Expand Down
4 changes: 2 additions & 2 deletions Homebrew/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ You change your path by adding `/usr/local/bin` to your `PATH` environment varia
This can be done on a per-user basis by adjusting `PATH` in your `~/.bash_profile`.
To do this, run:

```console
$ echo 'PATH="/usr/local/bin:$PATH"' >> ~/.bash_profile
```sh
echo 'PATH="/usr/local/bin:$PATH"' >> ~/.bash_profile
```

(If you're using `zsh`, you should do this for `~/.zshrc` in addition to
Expand Down
8 changes: 4 additions & 4 deletions Homebrew/Usage.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ brew update
**Note**: If that command fails you can manually download the directory of
formulas like this:

```console
$ cd /usr/local/Homebrew/
$ git fetch origin
$ git reset --hard origin/master
```sh
cd /usr/local/Homebrew/
git fetch origin
git reset --hard origin/master
```

To see if any of your formulas need to be updated:
Expand Down
16 changes: 8 additions & 8 deletions Node.js/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@ curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.31.1/install.sh | b

Then download Node and select your version by running:

```console
$ source ~/.bashrc # source your bashrc/zshrc to add nvm to PATH
$ command -v nvm # check the nvm use message
$ nvm install node # install most recent Node stable version
$ nvm ls # list installed Node version
$ nvm use node # use stable as current version
$ nvm ls-remote # list all the Node versions you can install
$ nvm alias default node # set the installed stable version as the default Node
```sh
source ~/.bashrc # source your bashrc/zshrc to add nvm to PATH
command -v nvm # check the nvm use message
nvm install node # install most recent Node stable version
nvm ls # list installed Node version
nvm use node # use stable as current version
nvm ls-remote # list all the Node versions you can install
nvm alias default node # set the installed stable version as the default Node
```

See the [documentation](https://github.com/creationix/nvm#installation) for information.
Expand Down
4 changes: 2 additions & 2 deletions Python/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@ installing, add `pyenv init` to your shell to enable shims and autocompletion
echo 'eval "$(pyenv init -)"' >> ~/.bash_profile
```

Restart your shell so the path changes take effect.
Restart your shell to make sure the path changes take effect.

```console
```sh
exec $SHELL
```

Expand Down
4 changes: 2 additions & 2 deletions Python/pip.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ sudo python get-pip.py

To verify `pip` is installed properly run

```console
$ pip --version
```sh
pip --version
```

If it returns a version `pip` was successfully installed.
Expand Down
14 changes: 7 additions & 7 deletions Python/virtualenv.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ pip install virtualenv
If you have a project in a directory called `my-project` you can set up
`virtualenv` for that project by running:

```console
$ cd my-project/
$ virtualenv venv
```sh
cd my-project/
virtualenv venv
```

If you want your `virtualenv` to also inherit globally installed packages run:
Expand All @@ -36,8 +36,8 @@ These commands create a `venv/` directory in your project where all
dependencies are installed. You need to **activate** it first though (in every
terminal instance where you are working on your project):

```console
$ source venv/bin/activate
```sh
source venv/bin/activate
```

You should see a `(venv)` appear at the beginning of your terminal prompt
Expand All @@ -53,8 +53,8 @@ projects.

To leave the virtual environment run:

```console
$ deactivate
```sh
deactivate
```

**Important**: Remember to add `venv` to your project's `.gitignore` file so
Expand Down
8 changes: 4 additions & 4 deletions Ruby/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ echo 'bundler' >> "$(brew --prefix rbenv)/default-gems"

When starting a Ruby project, you can have sandboxed collections of gems. This lets you have multiple collections of gems installed in different sandboxes, and specify (on a per-application basis) which sets of gems should be used. To have gems install into a sub-folder in your project directory for easy later removal / editing / testing, you can use a project gemset.

```console
$ echo '.gems' > <my_project_path>/.rbenv-gemsets
```sh
echo '.gems' > <my_project_path>/.rbenv-gemsets
```

Your gems will then get installed in `project/.gems`.
Expand All @@ -42,6 +42,6 @@ Your gems will then get installed in `project/.gems`.

If you use Google for finding your Gem documentation then you might want to consider saving a bit of time when installing gems by not including the documentation.

```console
$ echo 'gem: --no-document' >> ~/.gemrc
```sh
echo 'gem: --no-document' >> ~/.gemrc
```
4 changes: 2 additions & 2 deletions Ruby/RubyGems.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

[RubyGems](http://rubygems.org/), the Ruby package manager, should be installed on your machine if you previously have installed Ruby. Verify this by running:

```console
$ which gem
```sh
which gem
```

## Update RubyGems
Expand Down
6 changes: 3 additions & 3 deletions Scala/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ brew install scala sbt

(This step is optional) Update the `/usr/local/etc/sbtopts` by running the command below.

```console
$ echo '-J-XX:+CMSClassUnloadingEnabled' >> /usr/local/etc/sbtopts
$ echo '-J-Xmx2G' >> /usr/local/etc/sbtopts
```sh
echo '-J-XX:+CMSClassUnloadingEnabled' >> /usr/local/etc/sbtopts
echo '-J-Xmx2G' >> /usr/local/etc/sbtopts
```

## Scala Plugin for Eclipse
Expand Down
4 changes: 2 additions & 2 deletions SublimeText/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@

Let's create a shortcut through which we can launch Sublime Text from the command-line

```console
$ ln -s /Applications/Sublime\ Text.app/Contents/SharedSupport/bin/subl /usr/local/bin/subl
```sh
ln -s /Applications/Sublime\ Text.app/Contents/SharedSupport/bin/subl /usr/local/bin/subl
```

Now you can open a file with `subl myfile.py` or start a new project in the current directory with `subl .`.
Expand Down
6 changes: 3 additions & 3 deletions SystemPreferences/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ suggestions. Always choose the setting that makes the most sense to you.**
- _Other settings_
- Remove _workspace auto-switching_ by running the following command:

```console
$ defaults write com.apple.dock workspaces-auto-swoosh -bool NO
$ killall Dock # Restart the Dock process
```sh
defaults write com.apple.dock workspaces-auto-swoosh -bool NO
killall Dock # Restart the Dock process
```

## Finder
Expand Down
20 changes: 10 additions & 10 deletions Vagrant/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,34 +32,34 @@ brew cask install vagrant-manager

Add the Vagrant box you want to use. We'll use Ubuntu 12.04 for the following example.

```console
$ vagrant box add precise64 https://vagrantcloud.com/hashicorp/boxes/precise64/versions/1.1.0/providers/virtualbox.box
```sh
vagrant box add precise64 https://vagrantcloud.com/hashicorp/boxes/precise64/versions/1.1.0/providers/virtualbox.box
```

You can find more boxes at [Vagrant Cloud](https://app.vagrantup.com/boxes/search).

Now create a test directory and `cd` into the test directory. Then we'll initialize the vagrant machine.

```console
$ vagrant init precise64
```sh
vagrant init precise64
```

Now lets start the machine using the following command.

```console
$ vagrant up
```sh
vagrant up
```

You can ssh into the machine now.

```console
$ vagrant ssh
```sh
vagrant ssh
```

Halt the vagrant machine now.

```console
$ vagrant halt
```sh
vagrant halt
```

Other useful commands are `suspend` and `destroy`.
18 changes: 9 additions & 9 deletions Vim/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,22 +28,22 @@ git clone https://github.com/amix/vimrc.git ~/.vim_runtime

To install the complete version, run:

```console
$ sh ~/.vim_runtime/install_awesome_vimrc.sh
```sh
sh ~/.vim_runtime/install_awesome_vimrc.sh
```

To install the _basic_ version, run:

```console
$ sh ~/.vim_runtime/install_basic_vimrc.sh
```sh
sh ~/.vim_runtime/install_basic_vimrc.sh
```

### Update

To update the vimrc scripts, run:

```console
$ cd ~/.vim_runtime && git pull --rebase && cd -
```sh
cd ~/.vim_runtime && git pull --rebase && cd -
```

## Maximum Awesome
Expand All @@ -60,9 +60,9 @@ git clone https://github.com/square/maximum-awesome.git

Then install it:

```console
$ cd maximum-awesome
$ rake
```sh
cd maximum-awesome
rake
```

> **NOTE:** the rake command will install all dependencies needed.
6 changes: 3 additions & 3 deletions iTerm/fzf.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Add any of these functions to your shell configuration file and apply the
changes to try them out. Or just paste the function in your terminal if you
just want to try it out without saving it.

```console
```sh
# fd - cd to selected directory
fd() {
local dir
Expand All @@ -41,7 +41,7 @@ fd() {
}
```

```console
```sh
# fh - search in your command history and execute selected command
fh() {
eval $( ([ -n "$ZSH_NAME" ] && fc -l 1 || history) | fzf +s --tac | sed 's/ *[0-9]* *//')
Expand All @@ -57,7 +57,7 @@ fh() {

Open up your shell config and add following function:

```console
```sh
# ch - browse chrome history
ch() {
local cols sep
Expand Down
2 changes: 1 addition & 1 deletion iTerm/zsh.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ git clone --recursive https://github.com/sorin-ionescu/prezto.git "${ZDOTDIR:-$H

Next create your `~/.zshrc` by running:

```console
```sh
setopt EXTENDED_GLOB
for rcfile in "${ZDOTDIR:-$HOME}"/.zprezto/runcoms/^README.md(.N); do
ln -s "$rcfile" "${ZDOTDIR:-$HOME}/.${rcfile:t}"
Expand Down

0 comments on commit deaa330

Please sign in to comment.