Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split all the things. #11

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Split all the things. #11

wants to merge 5 commits into from

Conversation

athoune
Copy link

@athoune athoune commented Jan 30, 2020

The code came from https://github.com/ppshobi/psonic/blob/master/src/Ingest.php#L144

I don't understand how to compute chunk size, it's not clea in the protocol documentation

The tests pass, but doesn't test large chunk.

See #10

@athoune athoune requested a review from xmonader January 30, 2020 20:25
@athoune
Copy link
Author

athoune commented Jan 30, 2020

bufsize was not correctly handled. Does all connection in the collection pool has the same buffer size?

@xmonader
Copy link
Owner

xmonader commented Feb 2, 2020

bufsize was not correctly handled. Does all connection in the collection pool has the same buffer size?

Yes, all the connections for the same client have the same backend server (whose bufsize is fixed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmonader xmonader Awaiting requested review from xmonader

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@athoune @xmonader