Skip to content

Commit

Permalink
fix: multisig file variables repetition (#36)
Browse files Browse the repository at this point in the history
* ci: check cache

* ci: normal install

* ci: cache yarn

* ci: cache yarn

* refactor: ready for merge with main

* feat: add version tags a/c to package.json version

* fix: break if dest id not present

* feat: add transfer entity relation in multisig

* refactor: function refactoring

* refactor: separate release functionality

* refactor: fix project.yaml and network.ts and updated batch and multisig

* ci: only run on PR

* fix: return fn if transfer not available in multisig

* build: bump versions

* chore: update polkadot block number

* fix: remove logger and add yarn build in ci
  • Loading branch information
ahmedali8 authored May 21, 2022
1 parent 7b65d85 commit 04663c7
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 7 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/create_branches.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ jobs:
- name: Print project.yaml
run: cat ./project.yaml

- name: Build project
run: yarn codegen && yarn build

- name: Delete branch
uses: dawidd6/action-delete-branch@v3
with:
Expand Down
6 changes: 0 additions & 6 deletions src/handlers/multisig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,6 @@ export async function executedMultisigHandler(event: SubstrateEvent): Promise<vo
// ensure tranfer entity exists before storing otherwise return
const transfer = await Transfer.get(transferId);
const transferPresent = transfer?.amount || transfer?.timestamp ? true : false;
logger.info("transfer amount >>> " + transfer?.amount);
logger.info("transfer status >>> " + transfer?.status);

// return if transfer not present in multisig
if (!transferPresent) return;
Expand All @@ -155,10 +153,6 @@ export async function executedMultisigHandler(event: SubstrateEvent): Promise<vo
await saveApproveRecord(accountId, multisigAccountId, timepointExtrinsicIdx, callHash);

// Update multisig record.
const transferId = `${event.block.block.header.number.toNumber()}-${event.extrinsic?.extrinsic.hash.toString()}`;
const blockNumber = event.block.block.header.number;
const fees = event.extrinsic ? calculateFees(event.extrinsic) : BigInt(0);
const approveRecords = await ApproveRecord.getByMultisigRecordId(multisigRecordId);
multisigRecord.approvals = approveRecords.map((approveRecord) => approveRecord.account);
multisigRecord.confirmExtrinsicIdx = `${blockNumber}-${event.extrinsic?.idx}`;
multisigRecord.fees = fees;
Expand Down
2 changes: 1 addition & 1 deletion src/scripts/chain-config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ const chainConfig = {
dictionary: "https://api.subquery.network/sq/AcalaNetwork/karura-dictionary",
},
[SupportedChains.POLKADOT]: {
startBlock: 10086261,
startBlock: 10399000,
chainId: "0x91b171bb158e2d3848fa23a9f1c25182fb8e20313b2c1eb49219da7a70ce90c3",
endpoint: "wss://polkadot.api.onfinality.io/public-ws",
dictionary: "https://api.subquery.network/sq/subquery/polkadot-dictionary",
Expand Down

0 comments on commit 04663c7

Please sign in to comment.