Skip to content

Commit

Permalink
Merge pull request #5081 from Tyriar/cleanup
Browse files Browse the repository at this point in the history
Simplify GH action names and remove test/api project
  • Loading branch information
Tyriar authored Jul 3, 2024
2 parents 147b542 + f44d68e commit 7970eb3
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 137 deletions.
1 change: 0 additions & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
"src/browser/tsconfig.json",
"src/common/tsconfig.json",
"src/headless/tsconfig.json",
"test/api/tsconfig.json",
"test/benchmark/tsconfig.json",
"test/playwright/tsconfig.json",
"addons/addon-attach/src/tsconfig.json",
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ jobs:
./node_modules/.bin/nyc report --reporter=cobertura
exit $EXIT_CODE
test-unit-parallel:
test-unit:
timeout-minutes: 20
strategy:
matrix:
Expand Down Expand Up @@ -150,7 +150,7 @@ jobs:
- name: Unit tests
run: yarn test-unit --forbid-only

test-playwright-parallel:
test-integration:
timeout-minutes: 20
strategy:
matrix:
Expand Down Expand Up @@ -191,11 +191,11 @@ jobs:
- name: Build demo
run: yarn build-demo
- name: Integration tests (core) # Tests use 50% workers to reduce flakiness
run: yarn test-playwright-${{ matrix.browser }} --workers=50% --forbid-only --suite=core
run: yarn test-integration-${{ matrix.browser }} --workers=50% --forbid-only --suite=core
- name: Integration tests (addon-canvas)
run: yarn test-playwright-${{ matrix.browser }} --workers=50% --forbid-only --suite=addon-canvas
run: yarn test-integration-${{ matrix.browser }} --workers=50% --forbid-only --suite=addon-canvas
- name: Integration tests (addon-webgl)
run: yarn test-playwright-${{ matrix.browser }} --workers=50% --forbid-only --suite=addon-webgl
run: yarn test-integration-${{ matrix.browser }} --workers=50% --forbid-only --suite=addon-webgl

release-dry-run:
needs: build
Expand Down
10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@
"lint-api": "eslint --no-eslintrc -c .eslintrc.json.typings --max-warnings 0 --no-ignore --ext .d.ts typings/",
"test": "npm run test-unit",
"posttest": "npm run lint",
"test-playwright": "node ./bin/test_playwright.js --workers=75%",
"test-playwright-chromium": "node ./bin/test_playwright.js --workers=75% \"--project=ChromeStable\"",
"test-playwright-firefox": "node ./bin/test_playwright.js --workers=75% \"--project=FirefoxStable\"",
"test-playwright-webkit": "node ./bin/test_playwright.js --workers=75% \"--project=WebKit\"",
"test-playwright-debug": "node ./bin/test_playwright.js --workers=1 --headed --timeout=30000",
"test-integration": "node ./bin/test_playwright.js --workers=75%",
"test-integration-chromium": "node ./bin/test_playwright.js --workers=75% \"--project=ChromeStable\"",
"test-integration-firefox": "node ./bin/test_playwright.js --workers=75% \"--project=FirefoxStable\"",
"test-integration-webkit": "node ./bin/test_playwright.js --workers=75% \"--project=WebKit\"",
"test-integration-debug": "node ./bin/test_playwright.js --workers=1 --headed --timeout=30000",
"test-unit": "node ./bin/test.js",
"test-unit-coverage": "node ./bin/test.js --coverage",
"test-unit-dev": "cross-env NODE_PATH='./out' mocha",
Expand Down
1 change: 0 additions & 1 deletion test/api/README.md

This file was deleted.

90 changes: 0 additions & 90 deletions test/api/TestUtils.ts

This file was deleted.

34 changes: 0 additions & 34 deletions test/api/tsconfig.json

This file was deleted.

1 change: 0 additions & 1 deletion tsconfig.all.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"references": [
{ "path": "./src/browser" },
{ "path": "./src/headless" },
{ "path": "./test/api" },
{ "path": "./test/benchmark" },
{ "path": "./test/playwright" },
{ "path": "./addons/addon-attach" },
Expand Down

0 comments on commit 7970eb3

Please sign in to comment.