fix badger setting

xyctruth · Dec 8, 2022 · 4551f3d · 4551f3d
1 parent 1d10690
commit 4551f3d
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 26 deletions.
diff --git a/pkg/storage/badger/store.go b/pkg/storage/badger/store.go
@@ -27,15 +27,12 @@ func NewStore(opt Options) storage.Store {
 	db, err := badger.Open(
 		badger.DefaultOptions(opt.Path).
 			WithCompression(options.Snappy).
-			WithNumLevelZeroTables(1).
-			WithNumLevelZeroTablesStall(2).
-			WithNumMemtables(1).
-			WithValueThreshold(1 << 20))
+			WithValueThreshold(1 << 10))
 
 	if err != nil {
 		panic(err)
 	}
-
+	err = db.Flatten(10)
 	s := &store{
 		db:  db,
 		opt: opt,

diff --git a/pkg/storage/badger/store_test.go b/pkg/storage/badger/store_test.go
@@ -1,11 +1,14 @@
 package badger
 
 import (
+	"fmt"
 	"io/ioutil"
 	"os"
 	"testing"
 	"time"
 
+	"github.com/dgraph-io/badger/v3/options"
+
 	"github.com/dgraph-io/badger/v3"
 	"github.com/stretchr/testify/require"
 	"github.com/xyctruth/profiler/pkg/storage"
@@ -358,11 +361,7 @@ func BenchmarkBadger1(b *testing.B) {
 	}
 	defer os.RemoveAll(dir)
 
-	db, err := badger.Open(
-		badger.DefaultOptions(dir).
-			WithLoggingLevel(3).
-			WithBypassLockGuard(true))
-
+	db, err := badger.Open(badger.DefaultOptions(dir))
 	if err != nil {
 		panic(err)
 	}
@@ -377,14 +376,19 @@ func BenchmarkBadger1(b *testing.B) {
 		panic(err)
 	}
 
+	s.metaSeq, err = s.db.GetSequence(MetaSequence, 1000)
+	if err != nil {
+		panic(err)
+	}
+
 	defer s.Release()
 	res, err := os.ReadFile("./trace_119091.gz")
 	if err != nil {
 		panic(err)
 	}
 
 	for i := 0; i < b.N; i++ {
-		_, err = s.SaveProfile("", res, time.Hour*24*7)
+		_, err = s.SaveProfile(fmt.Sprintf("%d", i), res, time.Hour*24*7)
 		if err != nil {
 			panic(err)
 		}
@@ -400,12 +404,11 @@ func BenchmarkBadger2(b *testing.B) {
 
 	db, err := badger.Open(
 		badger.DefaultOptions(dir).
-			WithLoggingLevel(3).
-			WithBypassLockGuard(true).
-			//WithNumMemtables(1).
-			//WithNumLevelZeroTables(1).
-			//WithNumLevelZeroTablesStall(2).
-			WithValueLogFileSize(64 << 20))
+			WithCompression(options.Snappy).
+			WithNumLevelZeroTables(1).
+			WithNumLevelZeroTablesStall(2).
+			WithNumMemtables(1).
+			WithValueThreshold(1 << 20))
 
 	if err != nil {
 		panic(err)
@@ -421,14 +424,19 @@ func BenchmarkBadger2(b *testing.B) {
 		panic(err)
 	}
 
+	s.metaSeq, err = s.db.GetSequence(MetaSequence, 1000)
+	if err != nil {
+		panic(err)
+	}
+
 	defer s.Release()
 	res, err := os.ReadFile("./trace_119091.gz")
 	if err != nil {
 		panic(err)
 	}
 
 	for i := 0; i < b.N; i++ {
-		_, err = s.SaveProfile("", res, time.Hour*24*7)
+		_, err = s.SaveProfile(fmt.Sprintf("%d", i), res, time.Hour*24*7)
 		if err != nil {
 			panic(err)
 		}

diff --git a/pkg/storage/badger/ttl_test.go b/pkg/storage/badger/ttl_test.go
@@ -10,21 +10,18 @@ func TestTTL(t *testing.T) {
 	//	err := os.Mkdir(dir, 0777)
 	//	require.Equal(t, nil, err)
 	//}
-	//s := NewStore(DefaultOptions(dir))
-	//
-	////for i := 0; true; i++ {
-	////	a, s, err := s.GetProfile(fmt.Sprintf("%d", i))
-	////	fmt.Sprintln(a, s, err)
-	////}
-	//
+	//s := NewStore(DefaultOptions(dir).WithGCInternal(time.Second * 10))
 	//for i := 0; true; i++ {
 	//	res, err := os.ReadFile("./trace_119091.gz")
 	//	if err != nil {
 	//		panic(err)
 	//	}
-	//	s, err := s.SaveProfile(fmt.Sprintf("%d", i), res, 10*time.Second)
+	//	s, err := s.SaveProfile(fmt.Sprintf("%d", i), res, 1*time.Minute)
 	//	if err != nil {
 	//		fmt.Println(s, err)
 	//	}
+	//	if i%1000 == 0 {
+	//		time.Sleep(time.Second * 10)
+	//	}
 	//}
 }