Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gemini support - Proof of concept #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Gemini support - Proof of concept #6

wants to merge 2 commits into from

Conversation

dottharun
Copy link

This PR adds support for the GEMINI API.

  • This is still only a proof of concept and may break since it's using the on_exit field of the plenary-job.
  • Consolidating with other APIs may require fully shifting to on_exit or using flags with conditionals.
  • I cannot test for OpenAPI and Anthropic as I don't have those keys.

spenserlee pushed a commit to spenserlee/dingllm.nvim that referenced this pull request Aug 24, 2024
Add Gemeni Support
a54d4ea 
Since Gemeni just dropped a free API key, I figured it was time to
integrate LLM to neovim.

This helpful PR was already present - just merged change for the freed
cursor update.

Source: <yacineMTB#6>
@dottharun
Copy link
Author

dottharun commented Aug 24, 2024 •
edited
Loading

Update: Removing the spec functions make_curl_args and handle_data, and using a single make_job function, similar to what is found in the kznllm.nvim, might be the best way forward to allow integration with other providers.

@spenserlee
Copy link

Thanks for a starting point for using Gemini. I added a change to my fork to use the streaming API method, removing the need to use the on_exit job callback and quicker feedback into the editor.

spenserlee@907ed42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dottharun @spenserlee