Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test to detect (platform specific) plugged-in scheduler #1

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

yannicks1
Copy link
Owner

@yannicks1 yannicks1 commented Feb 14, 2025

As requested by the reviewers for this PR, here is a unit test to validate the functionality of the platform specific pluggable scheduler.

working principle:
Via check_and_update_config() of a DummyPlatform we set the scheduler_cls of the parallel configs to point to a (platform specific) DummyScheduler. The DummyScheduler raises a ValueError which is caught in the pytest for validation.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@yannicks1 yannicks1 marked this pull request as ready for review February 14, 2025 00:56
@yannicks1 yannicks1 merged commit 57f8d55 into ysc-pluggable-scheduler Feb 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant