Fix/poetry installer #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaieslamiri
commented
Oct 3, 2022
kaieslamiri
commented
- fixed poetry installer
- fixed helper to make mypy execute correctly
- style - readme formatting.
- bumped version.
|
related issue : #95 |
Kludex
reviewed
Oct 3, 2022
pyproject.toml
Outdated
| @@ -9,7 +9,7 @@ license = "MIT" | |||
| name = "manage-fastapi" | |||
| readme = "README.md" | |||
| repository = "https://github.com/ycd/manage-fastapi" | |||
| version = "1.1.1" | |||
| version = "1.1.2" | |||
There was a problem hiding this comment.
I'll bump later...
Suggested change
| version = "1.1.2" | |
| version = "1.1.1" |
Kludex
reviewed
Oct 3, 2022
poetry.lock
Outdated
Comment on lines
986
to
990
| typed-ast = [] | ||
| typer = [] | ||
| typing-extensions = [] | ||
| urllib3 = [] | ||
| virtualenv = [] |
There was a problem hiding this comment.
The hashes are being removed here... Do you have poetry <1.2 locally?
There was a problem hiding this comment.
well have reverted it for now... will look deeper into it later
|
@Kludex, is it mergeable now ? |
Secrus
reviewed
Jan 8, 2023
| @@ -4,7 +4,7 @@ ENV PYTHONPATH "${PYTHONPATH}:/" | |||
| ENV PORT=8000 | |||
| {% if cookiecutter.packaging == "poetry" %} | |||
| # Install Poetry | |||
| RUN curl -sSL https://raw.githubusercontent.com/python-poetry/poetry/master/get-poetry.py | POETRY_HOME=/opt/poetry python && \ | |||
| RUN curl -sSL https://install.python-poetry.org | POETRY_HOME=/opt/poetry python && \ | |||
| cd /usr/local/bin && \ | |||
| ln -s /opt/poetry/bin/poetry && \ | |||
There was a problem hiding this comment.
New installer changes the way Poetry is installed (it's similar to how pipx does it), so this probably won't work as intended
There was a problem hiding this comment.
You mean on new Apple chips also ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.