Semaphore API #162
Merged
Semaphore API #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shishqa
force-pushed
the
shishqa/semaphore
branch
from
b998249 to
809d51d
Compare
Shishqa
force-pushed
the
shishqa/semaphore
branch
from
809d51d to
cce3e61
Compare
rekby
reviewed
Dec 22, 2023
ydb/examples/mutex.rs
Outdated
| println!("done"); | ||
|
|
||
| let mut handles: Vec<JoinHandle<()>> = vec![]; | ||
| for _ in range(0, 4) { |
There was a problem hiding this comment.
why range instead of for _ in 0..4?
|
|
||
| #[derive(Debug, serde::Serialize)] | ||
| #[allow(dead_code)] | ||
| pub struct SemaphoreSession { |
There was a problem hiding this comment.
Need to move wrappers of grpc messages to grpc_wrapper
Shishqa
commented
Jan 17, 2024
|
|
||
| #[derive(Clone)] | ||
| struct MethodControllers { | ||
| pub create_semaphore: Arc<RequestController<RawCreateSemaphoreResult>>, |
Shishqa
commented
Jan 17, 2024
| #[allow(dead_code)] | ||
| pub struct AcquireOptions { | ||
| #[builder(setter(strip_option), default)] | ||
| pub data: Option<Vec<u8>>, |
There was a problem hiding this comment.
make pub or pub(crate) consistent with the rest of the sdk
Shishqa
commented
Jan 17, 2024
| } | ||
|
|
||
| pub fn client(&self) -> CoordinationClient { | ||
| unimplemented!() |
Shishqa
commented
Jan 17, 2024
| Single, | ||
| Exclusive, | ||
| Custom(u64), | ||
| } |
There was a problem hiding this comment.
different methods for different options
Shishqa
commented
Jan 17, 2024
| Mutex, | ||
| Unbounded, | ||
| Custom(u64), | ||
| } |
There was a problem hiding this comment.
make different methods
Shishqa
commented
Jan 17, 2024
| _name: String, | ||
| _options: WatchOptions, | ||
| ) -> YdbResult<mpsc::Receiver<SemaphoreDescription>> { | ||
| unimplemented!() |
Shishqa
commented
Jan 17, 2024
| } else { | ||
| return Err(YdbError::Custom("unexpected session answer".to_string())); | ||
| } | ||
| println!("session started! {:?}", session_response); |
Shishqa
commented
Jan 17, 2024
| }, | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
/+ describe test
/+ update test
rekby
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information