Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix huge heap recovery #14449

Open
wants to merge 3 commits into
base: stream-nb-24.3.11.1-hotfix.7-hf.1
Choose a base branch
from
Open

Fix huge heap recovery #14449

wants to merge 3 commits into from
+172 −46

Conversation

robdrynkin
Copy link
Collaborator

Changelog entry

Fix hull huge heap recovery after changing minHugeBlobSizeInBytes for groups created on 24 2

Changelog category

  • Bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 11, 2025 •
edited
Loading

⚪ 2025-02-11 14:36:12 UTC Pre-commit check for 308f59d has started.
⚪ 2025-02-11 14:39:22 UTC Build linux-x86_64-release-asan is running...
🟢 2025-02-11 15:40:23 UTC Build successful.
⚪ 2025-02-11 15:40:41 UTC Tests are running...
🔴 2025-02-11 18:32:09 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10346 10232 0 37 30 47

🟢 2025-02-11 18:33:11 UTC ydbd size 5.6 GiB changed* by -24 Bytes, which is <= 0 Bytes vs stream-nb-24.3.11.1-hotfix.7-hf.1: OK

ydbd size dash stream-nb-24.3.11.1-hotfix.7-hf.1: cc68f4d merge: 308f59d diff diff %
ydbd size 5 971 161 536 Bytes 5 971 161 512 Bytes -24 Bytes -0.000%
ydbd stripped size 1 498 048 768 Bytes 1 498 048 000 Bytes -768 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 11, 2025 •
edited
Loading

⚪ 2025-02-11 14:38:26 UTC Pre-commit check for 308f59d has started.
⚪ 2025-02-11 14:41:02 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-02-11 15:47:30 UTC Build successful.
⚪ 2025-02-11 15:47:48 UTC Tests are running...
🔴 2025-02-11 17:14:30 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14637 13283 0 7 1301 46

🟢 2025-02-11 17:15:34 UTC ydbd size 8.2 GiB changed* by -6.8 KiB, which is <= 0 Bytes vs stream-nb-24.3.11.1-hotfix.7-hf.1: OK

ydbd size dash stream-nb-24.3.11.1-hotfix.7-hf.1: cc68f4d merge: 308f59d diff diff %
ydbd size 8 824 763 336 Bytes 8 824 756 400 Bytes -6.8 KiB -0.000%
ydbd stripped size 482 091 240 Bytes 482 091 112 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 11, 2025 •
edited
Loading

⚪ 2025-02-11 14:38:30 UTC Pre-commit check for 308f59d has started.
⚪ 2025-02-11 14:41:15 UTC Build linux-x86_64-release-clang14 is running...
🟢 2025-02-11 15:40:28 UTC Build successful.

SammyVimes
SammyVimes approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@SammyVimes SammyVimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SammyVimes SammyVimes SammyVimes approved these changes

@mvgorbunov mvgorbunov Awaiting requested review from mvgorbunov mvgorbunov is a code owner

@dcherednik dcherednik Awaiting requested review from dcherednik dcherednik is a code owner

@va-kuznecov va-kuznecov Awaiting requested review from va-kuznecov va-kuznecov is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robdrynkin @SammyVimes