Restore async replication #14465
Restore async replication #14465
Conversation
|
⚪ |
|
⚪ |
CyberROFL
dismissed stale reviews from pnv1, Gazizonoki, and ijon
via
3d5338c
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| if (!RewriteCreateViewQuery(query, dbRestoreRoot, isDb, dbPath, createViewFile.GetPath().Quote(), issues)) { | ||
| return Result<TRestoreResult>(dbPath, EStatus::BAD_REQUEST, issues.ToString()); | ||
| if (!RewriteCreateViewQuery(query, dbRestoreRoot, isDb, dbPath, issues)) { | ||
| return Result<TRestoreResult>(fsPath.GetPath(), EStatus::BAD_REQUEST, issues.ToString()); |
There was a problem hiding this comment.
This result with an error should be built using the dbPath, see for example RestoreTable result built here and every other (⭐) result with an error using a path to be built in this file.
(⭐) Except the RestoreChangefeeds function. I believe, it is also an error to use fsPath for the resulting error there.
Changelog entry
...
Changelog category
Additional information
...